Upgrade actions and modify Slack notification setup#3504
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions workflow to address CI annotation warnings by upgrading action dependencies and replacing an unmaintained Slack notification action with Slack’s official GitHub Action.
Changes:
- Bump core CI actions versions (checkout, setup-node, pnpm/action-setup).
- Replace
8398a7/action-slackwithslackapi/slack-github-actionand provide a custom incoming-webhook payload.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| value: "<${{ github.server_url }}/${{ github.repository }}|${{ github.repository }}>" | ||
| short: true | ||
| - title: "Message" | ||
| value: "${{ github.event.head_commit.message }}" |
There was a problem hiding this comment.
github.event.head_commit.message is only populated for certain events (notably push). If this workflow is later extended to workflow_dispatch/pull_request, this field will be empty and the Slack message will lose the commit context. Consider using a fallback (e.g. PR title for PR events, or github.sha) so the notification always has a useful message.
Suggested change
| value: "${{ github.event.head_commit.message }}" | |
| value: "${{ github.event.head_commit.message || github.event.pull_request.title || github.sha }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the CI annotation warnings: https://github.com/AdguardTeam/AdguardBrowserExtension/actions/runs/24205254914/job/70659293344#step:13:2 and https://github.com/AdguardTeam/AdguardBrowserExtension/actions/runs/24205254914/job/70659736957#step:3:2
I have to replace https://github.com/8398a7/action-slack with https://github.com/slackapi/slack-github-action because
8398a7/action-slackno longer maintained.